linux-kernel - Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10107.1354710942@warthog.procyon.org.uk>
Date:	Wed, 05 Dec 2012 12:35:42 +0000
From:	David Howells <dhowells@...hat.com>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	dhowells@...hat.com, Rusty Russell <rusty@...abs.org>,
	Michal Marek <mmarek@...e.cz>, linux-kernel@...r.kernel.org,
	James Hogan <james.hogan@...tec.com>
Subject: Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

Takashi Iwai <tiwai@...e.de> wrote:

> From: Takashi Iwai <tiwai@...e.de>
> Subject: [PATCH v2] MODSIGN: Avoid using .incbin in C source
> 
> Using the asm .incbin statement in C sources breaks any gcc wrapper which
> assumes that preprocessed C source is self-contained. Use a separate .S
> file to include the siging key and certificate.
> 
> Tested-by: Michal Marek <mmarek@...e.cz>
> Signed-off-by: Takashi Iwai <tiwai@...e.de>

Acked-by: David Howells <dhowells@...hat.com>

> +#define GLOBAL(name)	\
> +	.globl ASM_SYMBOL(name);	\
> +	ASM_SYMBOL(name):

This should perhaps be moved into a global header.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/