lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121206165325.GE1080@krava.brq.redhat.com> Date: Thu, 6 Dec 2012 17:53:25 +0100 From: Jiri Olsa <jolsa@...hat.com> To: Namhyung Kim <namhyung@...nel.org> Cc: Arnaldo Carvalho de Melo <acme@...stprotocols.net>, Ingo Molnar <mingo@...nel.org>, Peter Zijlstra <peterz@...radead.org>, LKML <linux-kernel@...r.kernel.org>, Namhyung Kim <namhyung.kim@....com>, Stephane Eranian <eranian@...gle.com> Subject: Re: [PATCH 2/5] perf hists: Exchange order of comparing items when collapsing hists On Fri, Dec 07, 2012 at 12:09:38AM +0900, Namhyung Kim wrote: > From: Namhyung Kim <namhyung.kim@....com> > > When comparing entries for collapsing put the given entry first, and > then the iterated entry. This is not the case of hist_entry__cmp() > when called if given sort keys don't require collapsing. So change > the order for the sake of consistency. It will be required for > matching and/or linking multiple hist entries. As discussed with Arnadlo, this change seems like changing the sort order... could you ellaborate how it is usefull in future? thanks, jirka > > Cc: Jiri Olsa <jolsa@...hat.com> > Cc: Stephane Eranian <eranian@...gle.com> > Signed-off-by: Namhyung Kim <namhyung@...nel.org> > --- > tools/perf/util/hist.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > index 82df1b26f0d4..d4471c21ed17 100644 > --- a/tools/perf/util/hist.c > +++ b/tools/perf/util/hist.c > @@ -285,7 +285,7 @@ static struct hist_entry *add_hist_entry(struct hists *hists, > parent = *p; > he = rb_entry(parent, struct hist_entry, rb_node_in); > > - cmp = hist_entry__cmp(entry, he); > + cmp = hist_entry__cmp(he, entry); > > if (!cmp) { > he_stat__add_period(&he->stat, period); > @@ -729,7 +729,7 @@ static struct hist_entry *hists__add_dummy_entry(struct hists *hists, > parent = *p; > he = rb_entry(parent, struct hist_entry, rb_node); > > - cmp = hist_entry__cmp(pair, he); > + cmp = hist_entry__cmp(he, pair); > > if (!cmp) > goto out; > @@ -759,7 +759,7 @@ static struct hist_entry *hists__find_entry(struct hists *hists, > > while (n) { > struct hist_entry *iter = rb_entry(n, struct hist_entry, rb_node); > - int64_t cmp = hist_entry__cmp(he, iter); > + int64_t cmp = hist_entry__cmp(iter, he); > > if (cmp < 0) > n = n->rb_left; > -- > 1.7.9.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists