lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CA+55aFy4Lv+_aPEakOJNR2F9PR=09jviT6Z70_NkWV5bSH5ABw@mail.gmail.com> Date: Thu, 6 Dec 2012 11:38:47 -0800 From: Linus Torvalds <torvalds@...ux-foundation.org> To: Henrik Rydberg <rydberg@...omail.se> Cc: Mel Gorman <mgorman@...e.de>, Jan Kara <jack@...e.cz>, linux-mm <linux-mm@...ck.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: Oops in 3.7-rc8 isolate_free_pages_block() Ok, I've applied the patch. Mel, some grepping shows that there is an old line that does end_pfn = ALIGN(low_pfn + pageblock_nr_pages, pageblock_nr_pages); which looks bogus. That should probably also use "+ 1" instead. But I'll consider that an independent issue, so I applied the one patch regardless. There is also a low_pfn += pageblock_nr_pages; low_pfn = ALIGN(low_pfn, pageblock_nr_pages) - 1; that looks suspicious for similar reasons. Maybe low_pfn = ALIGN(low_pfn + 1, pageblock_nr_pages) - 1; instead? Although that *can* result in the same low_pfn in the end, so maybe that one was correct after all? I just did some grepping, no actual semantic analysis... Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists