lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121206213909.GA625@polaris.bitmath.org> Date: Thu, 6 Dec 2012 22:39:09 +0100 From: "Henrik Rydberg" <rydberg@...omail.se> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Mel Gorman <mgorman@...e.de>, Jan Kara <jack@...e.cz>, linux-mm <linux-mm@...ck.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: Oops in 3.7-rc8 isolate_free_pages_block() > There is also a > > low_pfn += pageblock_nr_pages; > low_pfn = ALIGN(low_pfn, pageblock_nr_pages) - 1; > > that looks suspicious for similar reasons. Maybe > > low_pfn = ALIGN(low_pfn + 1, pageblock_nr_pages) - 1; > > instead? Although that *can* result in the same low_pfn in the end, so > maybe that one was correct after all? I just did some grepping, no > actual semantic analysis... Here is a totally obscure version: low_pfn |= pageblock_nr_pages - 1; It simply moves to the very end of the block, which seems to be what was intended. Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists