lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <50BFFBAE.4010300@marvell.com> Date: Thu, 06 Dec 2012 09:58:06 +0800 From: Qing Xu <qingx@...vell.com> To: Grant Likely <grant.likely@...retlab.ca> Cc: "rob@...dley.net" <rob@...dley.net>, "sameo@...ux.intel.com" <sameo@...ux.intel.com>, "haojian.zhuang@...il.com" <haojian.zhuang@...il.com>, "rob.herring@...xeda.com" <rob.herring@...xeda.com>, Qiao Zhou <zhouqiao@...vell.com>, Chao Xie <cxie4@...vell.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] Documentation: add docs for 88pm80x dt On 12/06/2012 06:55 AM, Grant Likely wrote: > On Wed, 5 Dec 2012 13:42:00 +0800, Qing Xu <qingx@...vell.com> wrote: >> From: Qing Xu <qingx@...vell.com> >> >> Signed-off-by: Qing Xu <qingx@...vell.com> > No commit text? > > This patch needs to be squashed together with the patch that changes the > driver. There is no value in separating them. > >> --- >> Documentation/devicetree/bindings/mfd/88pm80x.txt | 52 +++++++++++++++++++++ >> 1 files changed, 52 insertions(+), 0 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/mfd/88pm80x.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/88pm80x.txt b/Documentation/devicetree/bindings/mfd/88pm80x.txt >> new file mode 100644 >> index 0000000..8a0ed07 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/88pm80x.txt >> @@ -0,0 +1,52 @@ >> +* Marvell 88pm80x Power Management IC >> + >> +Required parent device properties: >> +- compatible : "marvell,88pm80x" >> +- reg : the I2C slave address for the 88pm80x chip >> +- interrupts : IRQ line for the 88pm80x chip >> +- interrupt-controller: describes the 88pm80x as an interrupt controller (has its own domain) >> +- #interrupt-cells : should be 1. >> + - The cell is the 88pm80x local IRQ number >> + >> +Optional parent device properties: >> +- marvell,88pm80x-irqmode: inicates whether interrupt status is cleared by read >> +- marvell,88pm80x-poweraddr: 88pm80x are multi-chips solution. <reg> stores the I2C address >> + of one chip, and this property stores the I2C address of >> + power related chip. >> +- marvell,88pm80x-gpadcaddr: 88pm80x are multi-chips solution. <reg> stores the I2C address >> + of one chip, and this property stores the I2C address of >> + gpadc related chip. > If it is multichip, then I would expect either a separate node for each > chip and these properties use phandles (instead of i2c addresses) to > point to the other chip nodes. > > Alternately, if the cluster is described using a single node, then you > can put all three i2c addresses into the 'reg' property. > > g. combined to one patch. please help review again. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists