linux-kernel - RE: [PATCH 1/2] regulator: lp8788-buck: Remove val array in lp8788_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A874F61F95741C4A9BA573A70FE3998F69E0574C@DQHE02.ent.ti.com>
Date:	Mon, 10 Dec 2012 02:27:13 +0000
From:	"Kim, Milo" <Milo.Kim@...com>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"Girdwood, Liam" <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] regulator: lp8788-buck: Remove val array in
 lp8788_init_dvs

> All elements of val array are zero.
> Simply set data argument to be 0 in lp8788_update_bits call and remove
> the val
> array.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Axel, sorry I disagree with this patch because DVS_PIN is meaningful.
In this case, explicit bit description is more important than code simplicity.
So I would keep it.

Thanks,
Milo