linux-kernel - Re: [patch 7/7] fs, notify: Add procfs fdinfo helper v6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.01.1212100320180.25777@nerf07.vanv.qr>
Date:	Mon, 10 Dec 2012 03:21:53 +0100 (CET)
From:	Jan Engelhardt <jengelh@...i.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Cyrill Gorcunov <gorcunov@...nvz.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Al Viro <viro@...iv.linux.org.uk>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Pavel Emelyanov <xemul@...allels.com>,
	James Bottomley <jbottomley@...allels.com>,
	Matthew Helsley <matt.helsley@...il.com>,
	aneesh.kumar@...ux.vnet.ibm.com, bfields@...ldses.org,
	oleg@...hat.com, rientjes@...gle.com, tvrtko.ursulin@...lan.co.uk,
	Andrey Vagin <avagin@...nvz.org>
Subject: Re: [patch 7/7] fs, notify: Add procfs fdinfo helper v6


On Saturday 2012-11-17 00:56, Andrew Morton wrote:
>>  | pos:	0
>>  | flags:	02000000
>>  | inotify wd:        3 ino:             9e7e
>>  | inotify wd:        2 ino:             a111
>>  | inotify wd:        1 ino:            6b149[...]
>
>This is a lousy output format.  It's sort-of like a sensible set of
>name-value tuples: "name:value name:value name:value" but
>
>c) inotify-wd is secretly printed in decimal while everything else
>   is in hex.
>
>What happens if we do something like the below (which will require a
>changelog update)?
>
>@@ -59,7 +59,7 @@ static int show_mark_fhandle(struct seq_
> 	f.handle.handle_type = ret;
> 	f.handle.handle_bytes = size * sizeof(u32);
> 
>-	ret = seq_printf(m, "fhandle-bytes: %8x fhandle-type: %8x f_handle: ",
>+	ret = seq_printf(m, "fhandle-bytes:%x fhandle-type:%x f_handle:",
> 			 f.handle.handle_bytes, f.handle.handle_type);

Why don't we actually make sure to print a 0x prefix when it's hex
and 0 on octal? Then it should be clear what base these lines are in.
(That would also be a good idea for the rest of procfs files, but I
reckon they cannot be easily changed.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/