[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1355361734.2164.9.camel@joe-AO722>
Date: Wed, 12 Dec 2012 17:22:14 -0800
From: Joe Perches <joe@...ches.com>
To: Jiri Kosina <trivial@...nel.org>
Cc: Martin Schwidefsky <schwidefsky@...ibm.com>,
Heiko Carstens <heiko.carstens@...ibm.com>,
linux390@...ibm.com, linux-s390@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [TRIVIAL PATCH 12/26] s390: Convert print_symbol to %pSR
On Wed, 2012-12-12 at 10:19 -0800, Joe Perches wrote:
> Use the new vsprintf extension to avoid any possible
> message interleaving.
[]
> diff --git a/arch/s390/kernel/traps.c b/arch/s390/kernel/traps.c
[]
> @@ -91,8 +91,9 @@ __show_trace(unsigned long sp, unsigned long low, unsigned long high)
> if (sp < low || sp > high - sizeof(*sf))
> return sp;
> sf = (struct stack_frame *) sp;
> - printk("([<%016lx>] ", sf->gprs[8] & PSW_ADDR_INSN);
> - print_symbol("%s)\n", sf->gprs[8] & PSW_ADDR_INSN);
> + printk("([<%016lx>] %pSR\n",
Sorry, this is defective, it needs a trailing ')' like:
+ printk("([<%016lx>] %pSR)\n",
> @@ -102,16 +103,18 @@ __show_trace(unsigned long sp, unsigned long low, unsigned long high)
> if (sp <= low || sp > high - sizeof(*sf))
> return sp;
> sf = (struct stack_frame *) sp;
> - printk(" [<%016lx>] ", sf->gprs[8] & PSW_ADDR_INSN);
> - print_symbol("%s\n", sf->gprs[8] & PSW_ADDR_INSN);
> + printk(" [<%016lx>] %pSR\n",
here too
I'll resubmit.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists