linux-kernel - Re: [PATCHv3 4/7] gpu: host1x: Add debug support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1355412191.12036.2.camel@joe-AO722>
Date:	Thu, 13 Dec 2012 07:23:11 -0800
From:	Joe Perches <joe@...ches.com>
To:	Terje Bergstrom <tbergstrom@...dia.com>
Cc:	thierry.reding@...onic-design.de, dev@...xeye.de,
	linux-tegra@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	amerilainen@...dia.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 4/7] gpu: host1x: Add debug support

On Thu, 2012-12-13 at 16:04 +0200, Terje Bergstrom wrote:
> Add support for host1x debugging. Adds debugfs entries, and dumps
> channel state to UART in case of stuck job.

trivial note:

[]

> diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h
[]
> +void host1x_debug_output(struct output *o, const char *fmt, ...);

This should be marked __printf(2, 3)
so the compiler verifies format and argument types.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/