lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Dec 2012 17:33:39 +0200 From: Terje Bergström <tbergstrom@...dia.com> To: Lucas Stach <dev@...xeye.de> CC: "thierry.reding@...onic-design.de" <thierry.reding@...onic-design.de>, "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>, "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, Arto Merilainen <amerilainen@...dia.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCHv3 0/7] Support for Tegra 2D hardware On 13.12.2012 17:03, Lucas Stach wrote: > You are still doing the allocation the IMHO wrong way around. I thought > we agreed to do all the allocations in host1x, which obviously means not > using the cma_gem_helpers anymore, but introducing a new native host1x > object to back GEM/V4L/whatever objects. IMHO the current approach is a > clear layering violation and makes proper IOMMU support a lot harder. It > would also allow to get rid of all the indirections and ifdefs in host1x > memmgr, as host1x would only have to deal with it's native objects. > > All the complexity of converting host1x to GEM objects should be located > in tegradrm and not be scattered between different modules. > > Did you leave this out on purpose in this version of the patchset? Forgot to mention that, as IOMMU and consequently the "proper" allocation support was planned as a follow-up. I wanted to keep the scope of this set as small as possible. The plan we agreed on still holds. Terje >> * tegradrm has a global variable. Plan was to hide that behind a >> virtual device, and use that as DRM root device. That plan went >> bad once the FB CMA helper used the device for trying to allocate >> memory. > See above, we should get rid of the helpers and do all allocations > within host1x. I noticed that IOMMU and not using the CMA FB helper is now exynos managed to do this. Terje -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists