[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1355474528-13094-1-git-send-email-sivaramn@nvidia.com>
Date: Fri, 14 Dec 2012 10:42:08 +0200
From: Sivaram Nair <sivaramn@...dia.com>
To: <ccross@...roid.com>, <santosh.shilimkar@...com>, <khilman@...com>,
<rjw@...k.pl>, <daniel.lezcano@...aro.org>
CC: <linux-kernel@...r.kernel.org>, Sivaram Nair <sivaramn@...dia.com>
Subject: [PATCH 1/1] cpuidle: coupled: fix ready counter decrement
The ready_waiting_counts atomic variable is compared against the wrong
online cpu count. The latter is computed incorrectly using logical-OR
instead of bit-OR. This patch fixes that.
Signed-off-by: Sivaram Nair <sivaramn@...dia.com>
---
drivers/cpuidle/coupled.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
index 3265844..2a297f8 100644
--- a/drivers/cpuidle/coupled.c
+++ b/drivers/cpuidle/coupled.c
@@ -209,7 +209,7 @@ inline int cpuidle_coupled_set_not_ready(struct cpuidle_coupled *coupled)
int all;
int ret;
- all = coupled->online_count || (coupled->online_count << WAITING_BITS);
+ all = coupled->online_count | (coupled->online_count << WAITING_BITS);
ret = atomic_add_unless(&coupled->ready_waiting_counts,
-MAX_WAITING_CPUS, all);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists