linux-kernel - Re: [PATCH 2/2] spi: devicetree: add support for loopback mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121215145546.GA15606@arwen.pp.htv.fi>
Date:	Sat, 15 Dec 2012 16:55:46 +0200
From:	Felipe Balbi <balbi@...com>
To:	Grant Likely <grant.likely@...retlab.ca>
CC:	Felipe Balbi <balbi@...com>,
	<spi-devel-general@...ts.sourceforge.net>, <rob@...dley.net>,
	<rob.herring@...xeda.com>, <devicetree-discuss@...ts.ozlabs.org>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH 2/2] spi: devicetree: add support for loopback mode

On Sat, Dec 15, 2012 at 12:32:24AM +0000, Grant Likely wrote:
> On Wed, 12 Dec 2012 10:46:00 +0200, Felipe Balbi <balbi@...com> wrote:
> > there are a few spi master drivers which make
> > use of that flag but there is no way to pass it
> > through devicetree.
> > 
> > This patch just creates a way to pass SPI_LOOP
> > via devicetree.
> 
> I don't understand how this would be useful since loopback mode is
> really just a test feature. Is there any reason to do loopback for
> something other than test?
> 
> I think it would be better to add a sysfs or debugfs property to
> manipulate the SPI_LOOP flag from userspace. What do you think?

might be nicer in the long run, indeed. Want me to look into it, or do
you wanna do it yourself ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)