linux-kernel - Re: [PATCH 2/3] wlan-ng/prism2mgmt.c: formated too long lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121217140851.GR5083@mwanda>
Date:	Mon, 17 Dec 2012 17:08:51 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sebastian Wankerl <sisewank@....cs.fau.de>
Cc:	linux-kernel@...informatik.uni-erlangen.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Sebastian Wankerl 
	<sisewank@...i49man10.informatik.uni-erlangen.de>,
	Sebastian Ehrenfels <qi50dube@....cs.fau.de>
Subject: Re: [PATCH 2/3] wlan-ng/prism2mgmt.c: formated too long lines

On Mon, Dec 17, 2012 at 02:38:02PM +0100, Sebastian Wankerl wrote:
> From: Sebastian Wankerl <sisewank@...i49man10.informatik.uni-erlangen.de>
> 

We allow long lines for string literals actually.  Or you can break
it up.

> Signed-off-by: Sebastian Wankerl <sisewank@....cs.fau.de> 
> Signed-off-by: Sebastian Ehrenfels <qi50dube@....cs.fau.de>
> 
> ---
>  drivers/staging/wlan-ng/prism2mgmt.c |   20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index 62b94b0..4b3db73 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -1144,9 +1144,9 @@ int prism2mgmt_wlansniff(wlandevice_t *wlandev, void *msgp)
>  			/* Enable the port */
>  			result = hfa384x_drvr_enable(hw, 0);
>  			if (result) {
> -				pr_debug
> -				("failed to enable port to presniff setting, result=%d\n",
> -				     result);
> +				pr_debug(
> +					"failed to enable port to presniff setting,"
                                                                                   ^
Space needed.

You may as well put the string on the same line as the pr_debug().
It only costs you one char.

				pr_debug("failed to enable port for sniffing, "
					 "result = %d", result);

> +					"result=%d\n", result);
>  				goto failed;
>  			}

	[ snip ]

>  				/* Disable the port */
>  				result = hfa384x_drvr_disable(hw, 0);
>  				if (result) {
> -					pr_debug
> -					    ("failed to enable port for sniffing, result=%d\n",
> -					     result);
> +					pr_debug(
> +						"failed to enable port for "
                                                           ^^^^^^
Disable.

> +						"sniffing, result=%d\n",
> +						result);
>  					goto failed;
>  				}
>  			}

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/