linux-kernel - Re: [PATCH 3/3] wlan-ng/prism2mgmt.c Replace printk(...) with netdev_warn, netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121217141345.GS5083@mwanda>
Date:	Mon, 17 Dec 2012 17:13:45 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sebastian Wankerl <sisewank@....cs.fau.de>
Cc:	linux-kernel@...informatik.uni-erlangen.de,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Sebastian Wankerl 
	<sisewank@...i49man10.informatik.uni-erlangen.de>,
	Sebastian Ehrenfels <qi50dube@....cs.fau.de>
Subject: Re: [PATCH 3/3] wlan-ng/prism2mgmt.c Replace printk(...) with
 netdev_warn, netdev_err

On Mon, Dec 17, 2012 at 02:38:03PM +0100, Sebastian Wankerl wrote:
> @@ -261,15 +265,17 @@ int prism2mgmt_scan(wlandevice_t *wlandev, void *msgp)
>  					HFA384x_RID_CREATEIBSS,
>  					HFA384x_CREATEIBSS_JOINCREATEIBSS);
>  		if (result) {
> -			printk(KERN_ERR "Failed to set CREATEIBSS.\n");
> +			netdev_err(wlandev->netdev,
> +				"Failed to set CREATEIBSS.\n");
>  			msg->resultcode.data =
>  			    P80211ENUM_resultcode_implementation_failure;
>  			goto exit;
>  		}
>  		result = hfa384x_drvr_enable(hw, 0);
>  		if (result) {
> -			printk(KERN_ERR "drvr_enable(0) failed. "
> -			       "result=%d\n", result);
> +			netdev_err(wlandev->netdev,
> +				"drvr_enable(0) failed. " "result=%d\n",
                                                        ^^^

Delete this.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/