linux-kernel - Question about using new request_threaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <50CF361A.1030203@gmail.com>
Date:	Mon, 17 Dec 2012 16:11:22 +0100
From:	Marcos Lois Bermúdez <marcos.discalis@...il.com>
To:	linux-kernel@...r.kernel.org
Subject: Question about using new request_threaded_irq

Hi,

I'm downloaded kernel sources 3.2.27, and now I'm writing a device 
driver for a SPI device, i make some kernel drivers in the past, so now 
I'm surfing the source tree to see the new mode to make things.

My driver need handle hardware interrupts, in the past i use 
request_irq, but now there is a request_threaded_irq that makes more 
easy to have a top / bottom processing. But I'm confuse, after read the 
inner implementation of request_threaded_irq and see some drivers that 
use it. For my understand if i call for example:

request_threaded_irq(irqmum, NULL, irq_handle, IRQF_TRIGGER_FALLING, 
DEVICE_NAME, priv);

This seem to make a old Hard IRQ handler, and inside of this handler 
sleep APIs can't be used, but i see some SPI drivers that seem to 
register a IRQ of this form and make API calls that can sleep in the 
handler. Ex: drivers/input/touchscreen/ad7877.c it register the IRQ as:

err = request_threaded_irq(spi->irq, NULL, ad7877_irq,
                    IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
                    spi->dev.driver->name, ts);

And inside of ad7877_irq make a block call:

static irqreturn_t ad7877_irq(int irq, void *handle)
{
..
error = spi_sync(ts->spi, &ts->msg);
..
}

Is this ok?
With the new interface 'request_threaded_irq' all the IRQ are 
implemented on a thread?
Do i need to create a handler for thread and pass it to 
'request_threaded_irq', and if yes, why a lot of drivers, only pass 
quick_check_handler and make hard processing on it?

Excuse my poor English.

Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/