linux-kernel - Re: [PATCH] cifs: Do not enable debugging code by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH2r5mt=4ZoGR_4hP52uHsZabXpPfh1sa1X0GSg6W4=fawNFnA@mail.gmail.com>
Date:	Mon, 17 Dec 2012 09:30:33 -0600
From:	Steve French <smfrench@...il.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, Joe Perches <joe@...ches.com>,
	Jeff Layton <jlayton@...hat.com>,
	Steve French <sfrench@...ba.org>, linux-cifs@...r.kernel.org
Subject: Re: [PATCH] cifs: Do not enable debugging code by default

I don't think taking out debugging makes sense - we need debugging a
lot more often than expected even to diagnose user errors (usually
relating to session establishment failures, since we are very limited
in how much information can be passed back in mount).   If we had
dynamic trace points for cifs and for common vfs entry points, or if
the distros shipped dual cifs modules (one with debugging and one
without), I wouldn't mind disabling it - but multiple times a month we
have to diagnose user problems (sometimes user errors, sometimes
server bugs etc.) by enabling debugging.

On Mon, Dec 17, 2012 at 3:38 AM, Borislav Petkov <bp@...en8.de> wrote:
> Debugging code is generally disabled in the configurator since it is
> only for devs and testers and not for the majority of the installations.
>
> Cc: Joe Perches <joe@...ches.com>
> Cc: Jeff Layton <jlayton@...hat.com>
> Cc: Steve French <sfrench@...ba.org>
> Cc: linux-cifs@...r.kernel.org
> Signed-off-by: Borislav Petkov <bp@...en8.de>
> ---
>  fs/cifs/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
> index 21ff76c22a17..241a0e2853c5 100644
> --- a/fs/cifs/Kconfig
> +++ b/fs/cifs/Kconfig
> @@ -124,7 +124,6 @@ config CIFS_ACL
>
>  config CIFS_DEBUG
>         bool "Enable CIFS debugging routines"
> -       default y
>         depends on CIFS
>         help
>            Enabling this option adds helpful debugging messages to
> --
> 1.8.1.rc2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/