linux-kernel - Re: [PATCH 2/2] dma: dw_dmac: clear suspend during termination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1355758017.31620.110.camel@smile>
Date:	Mon, 17 Dec 2012 17:26:57 +0200
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Vinod Koul <vinod.koul@...el.com>,
	spear-devel <spear-devel@...t.st.com>,
	linux-kernel@...r.kernel.org,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH 2/2] dma: dw_dmac: clear suspend during termination

On Mon, 2012-12-17 at 20:42 +0530, Viresh Kumar wrote: 
> On 17 December 2012 19:37, Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> >
> > Clear DWC_CFGL_CH_SUSP bit during termination if the channel
> > was paused.
> >
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Insufficient commit log :(
> You don't have to say here, what you are doing, but why you are doing it.

Fighting against bug. The workflow in our case is to a) pause the dma,
b) do something in the slave driver, c) terminate all transfers, d)
submit new transfer. But d) doesn't happen because the channel is still
paused.

> Please mention the reason here first, then repost the series after getting my
> comments

Okay.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/