linux-kernel - Re: [PATCH] scripts: add checkmaintainers.py

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1355758544.13361.14.camel@joe-AO722>
Date:	Mon, 17 Dec 2012 07:35:44 -0800
From:	Joe Perches <joe@...ches.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Michal Marek <mmarek@...e.cz>,
	Cesar Eduardo Barros <cesarb@...arb.net>,
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] scripts: add checkmaintainers.py

On Mon, 2012-12-17 at 11:27 +0100, Borislav Petkov wrote:
> On Mon, Dec 17, 2012 at 11:14:24AM +0100, Michal Marek wrote:
> > On 14.12.2012 23:19, Cesar Eduardo Barros wrote:
> > > This small script checks the file patterns in the MAINTAINERS file.
> > > 
> > > For every file pattern, it checks if the pattern matches any file or
> > > directory in the kernel tree, printing the patterns which do not have a
> > > match.
> > 
> > Can't this be added as a warning to scripts/get_maintainer.pl instead?
> 
> Yep, it definitely makes more sense than having a standalone script.

I'm not so sure of that myself.

I think maybe it should go into checkpatch.

I do have a similar script as a get_maintainers variant.

Adding a --verify-patterns option seems off-topic to
the generic tool use of get_maintainers.

There's a fair amount of tedium for people to do more
than determine there is a pattern that doesn't match
files in git.

Doing the work that Cesar did to find the commit that
makes a pattern valid/invalid when renames or deletions
occur is the chore that could be automated.

Perhaps Cesar can use his script as a starting point
to find those pattern invalidating commits or maybe
add the capability (or a --strict check) to checkpatch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/