linux-kernel - Re: [PATCH] usb: gadget zero: avoid unnecessary reinit of data in f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50CF548C.2080500@st.com>
Date:	Mon, 17 Dec 2012 18:21:16 +0100
From:	Armando Visconti <armando.visconti@...com>
To:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
Cc:	"balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	Pratyush ANAND <pratyush.anand@...com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	spear-devel <spear-devel@...t.st.com>
Subject: Re: [PATCH] usb: gadget zero: avoid unnecessary reinit of data in
 f_sourcesink

On 12/17/2012 04:45 PM, Sebastian Andrzej Siewior wrote:
> On Thu, Dec 13, 2012 at 03:11:19PM +0100, Armando Visconti wrote:
>> In the IN case, since the USB request is allocated only when
>> the source/sink function is started and never freed, the USB ept
>> buffer needs to be inited only at the beginning. This change
>                       ^^^^^^
>> results into a more performant g_zero module, especially when
>> 'pattern=1' is selected.
>
> Besides that the patch looks fine :)

Do you mean that 'inited' should be changed with 'initialized'?
Oh ... my poor english... :(

Rgds,
Arm

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/