linux-kernel - Re: [PATCH] SUNRPC: continue run over clients list on PipeFS event instead of break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FA345DA4F4AE44899BD2B03EEEC2FA91194E28F@sacexcmbx05-prd.hq.netapp.com>
Date:	Mon, 17 Dec 2012 17:21:57 +0000
From:	"Myklebust, Trond" <Trond.Myklebust@...app.com>
To:	Stanislav Kinsbursky <skinsbursky@...allels.com>
CC:	"linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...nvz.org" <devel@...nvz.org>
Subject: Re: [PATCH] SUNRPC: continue run over clients list on PipeFS event
 instead of break

On Mon, 2012-12-17 at 20:18 +0300, Stanislav Kinsbursky wrote:
> There are SUNRPC clients, which program doesn't have pipe_dir_name. These
> clients can be skipped on PipeFS events, because nothing have to be created or
> destroyed. But instead of breaking in case of such a client was found, search
> for suitable client over clients list have to be continued. Otherwise some
> clients could not be covered by PipeFS event handler.
> 
> Signed-off-by: Stanislav Kinsbursky <skinsbursky@...allels.com>
> Cc: stable@...r.kernel.org [>= v3.4]
> ---
>  net/sunrpc/clnt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index cdc7564..10b18b2 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -234,7 +234,7 @@ static struct rpc_clnt *rpc_get_client_for_event(struct net *net, int event)
>  	spin_lock(&sn->rpc_client_lock);
>  	list_for_each_entry(clnt, &sn->all_clients, cl_clients) {
>  		if (clnt->cl_program->pipe_dir_name == NULL)
> -			break;
> +			continue;
>  		if (rpc_clnt_skip_event(clnt, event))
>  			continue;
>  		if (atomic_inc_not_zero(&clnt->cl_count) == 0)
> 

Thanks Stanislav! Applied.
-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/