linux-kernel - Re: [PATCH] libata: Shut up annoying native

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Dec 2012 13:01:59 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Borislav Petkov <bp@...en8.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org
Subject: Re: [PATCH] libata: Shut up annoying native_sectors warning

On Thu, 20 Dec 2012 13:25:55 +0100
Borislav Petkov <bp@...en8.de> wrote:

> I'm getting this
> 
> drivers/ata/libata-core.c: In function ‘ata_hpa_resize’:
> drivers/ata/libata-core.c:1397:3: warning: ‘native_sectors’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> for a couple of kernel releases now with gcc (Debian 4.7.2-4) 4.7.2.
> 
> And the warning is bogus because ata_read_native_max_address either
> returns a sensible max_sectors aka native_sectors through its second
> arg pointer or an error value which is properly handled in its caller
> ata_hpa_resize().
> 
> So shut up gcc already.

And ensure it won't be noticed if a real problem is found. So we go from
warning for a few people who ignore it, to silence for everyone if a real
bug appears

Net lose IMHO - better to file a gcc bug report

Alan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/