linux-kernel - Re: [PATCH] n_gsm.c: add tx_lock in gsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121220130626.6b4aea39@pyramind.ukuu.org.uk>
Date:	Thu, 20 Dec 2012 13:06:26 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Xiao, Jin" <jin.xiao@...el.com>
Cc:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl>,
	"rusty@...tcorp.com.au" <rusty@...tcorp.com.au>,
	"Douglas, William" <william.douglas@...el.com>,
	"sboyd@...eaurora.org" <sboyd@...eaurora.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"jslaby@...e.cz" <jslaby@...e.cz>,
	"Pillet, VincentX" <vincentx.pillet@...el.com>
Subject: Re: [PATCH] n_gsm.c: add tx_lock in gsm_send

On Thu, 20 Dec 2012 12:13:07 +0000
"Xiao, Jin" <jin.xiao@...el.com> wrote:

> Alan, 
> 
> Thanks. But the comment makes me confused. As we see, gsm->output is called by gsm_data_kick too, and it's in the tx_lock...

That would be a bug too or I guess we could finally give in on trying to
keep tty write paths not using spin_lock_irq and fix any oddments that
blow up. That might actually be the right thing to do as its caused
problems in other places too, and the USB tty drivers are now well
behaved.

Your patch doesn't make it any worse however so I agree it might as well
go in.

Alan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/