lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 20 Dec 2012 13:41:47 -0800
From:	Simon Glass <>
To:	Dmitry Torokhov <>
Cc:	LKML <>,
	"" <>,
	Rob Landley <>,
	Grant Likely <>,
	Devicetree Discuss <>,
	Roland Stigge <>,,
	Vincent Palatin <>,
	Wolfram Sang <>,
	Felipe Balbi <>,
	Sourav Poddar <>,
	Luigi Semenzato <>,
	Olof Johansson <>,
	Rob Herring <>,
	Stephen Warren <>
Subject: Re: [PATCH] RFC: input: Extend matrix-keypad device tree binding

Hi Dmitry,

On Thu, Dec 20, 2012 at 1:13 PM, Dmitry Torokhov
<> wrote:
> Hi Simon,
> On Thu, Dec 20, 2012 at 12:23:58PM -0800, Simon Glass wrote:
>> For the key repeat feature, we need to set this after the input device
>> is registered. So we would need to add a matrix_keypad_setup_input() or
>> similar to be called by the driver after input_register_device(). I am
>> less keen on that idea, and less again on the alternative of perhaps
>> matrix_keypad_register_device() which does input_register_device() and
>> then sets up the key repeat. Thoughts?
> No, we already have default rate and delay. Unless you can prove that
> random firmware writer's idea of appropriate delay and rate is better
> then current default - for everyone - and then can successfully argue
> that that obviously best delay/rate combo should not replace the current
> one but stay only in DT bindings, let's keep relying on users adjusting
> their own preferences from respective desktop environments/console/etc.

Seems reasonable. My only comment on this is that the device tree
comes from kernel, not firmware. This lets us configure an embedded
system easily (where the user may not have access to repeat rate

Grant are you OK with me just dropping the repeat settings, and
keeping the other two? If so I will respin the patch.


> Thanks.
> --
> Dmitry
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists