linux-kernel - Re: [PATCH] epoll: stop comparing pointers with 0 in self-test app

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50D3CFBF.50902@gmail.com>
Date:	Thu, 20 Dec 2012 21:55:59 -0500
From:	Daniel Hazelton <dshadowwolf@...il.com>
To:	Sasha Levin <sasha.levin@...cle.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	"Paton J. Lewis" <palewis@...be.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] epoll: stop comparing pointers with 0 in self-test app

I don't see anything obviously wrong here...
Reviewed-By: Daniel Hazelton <dshadowwolf@...il.com>

On 12/20/2012 02:11 PM, Sasha Levin wrote:
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> ---
>   tools/testing/selftests/epoll/test_epoll.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/epoll/test_epoll.c b/tools/testing/selftests/epoll/test_epoll.c
> index 4a14a7f..1034ed4 100644
> --- a/tools/testing/selftests/epoll/test_epoll.c
> +++ b/tools/testing/selftests/epoll/test_epoll.c
> @@ -199,8 +199,8 @@ int main(int argc, char **argv)
>
>   	epoll_items = malloc(n_epoll_items * sizeof(struct epoll_item_private));
>
> -	if (epoll_set < 0 || epoll_items == 0 || write_thread_data.fds == 0 ||
> -		read_thread_data == 0 || read_threads == 0)
> +	if (epoll_set < 0 || !epoll_items || write_thread_data.fds == NULL ||
> +		!read_thread_data || !read_threads)
>   		goto error;
>
>   	if (sysconf(_SC_NPROCESSORS_ONLN) < 2) {
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/