lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Dec 2012 20:29:50 +0800 From: Alex Shi <lkml.alex@...il.com> To: Namhyung Kim <namhyung@...nel.org> Cc: Alex Shi <alex.shi@...el.com>, Preeti U Murthy <preeti@...ux.vnet.ibm.com>, rob@...dley.net, mingo@...hat.com, peterz@...radead.org, gregkh@...uxfoundation.org, andre.przywara@....com, rjw@...k.pl, paul.gortmaker@...driver.com, akpm@...ux-foundation.org, paulmck@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org, pjt@...gle.com, vincent.guittot@...aro.org Subject: Re: [PATCH 08/18] sched: consider runnable load average in move_tasks On Fri, Dec 21, 2012 at 12:43 PM, Namhyung Kim <namhyung@...nel.org> wrote: > On Wed, 12 Dec 2012 14:26:44 +0800, Alex Shi wrote: >> On 12/12/2012 12:41 PM, Preeti U Murthy wrote: >>> Also why can't p->se.load_avg_contrib be used directly? as a return >>> value for task_h_load_avg? since this is already updated in >>> update_task_entity_contrib and update_group_entity_contrib. >> >> No, only non task entity goes to update_group_entity_contrib. not task >> entity. > > ??? > > But task entity goes to __update_task_entity_contrib()? yes, but if the task is in a task_group, its load weight need to reweight with its task_group's fraction. can not use direct load weight in balancing calculation, so in move_tasks, it uses task_h_load. > > > /* Compute the current contribution to load_avg by se, return any delta */ > static long __update_entity_load_avg_contrib(struct sched_entity *se) > { > long old_contrib = se->avg.load_avg_contrib; > > if (entity_is_task(se)) { > __update_task_entity_contrib(se); > } else { > __update_tg_runnable_avg(&se->avg, group_cfs_rq(se)); > __update_group_entity_contrib(se); > } > > return se->avg.load_avg_contrib - old_contrib; > } > > > Thanks, > Namhyung > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Thanks Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists