linux-kernel - Re: [PATCH] rtk_btusb: Add Bluetooth firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Dec 2012 23:26:22 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	dwmw2@...radead.org, Champion Chen <champion_chen@...lsil.com.cn>
Subject: Re: [PATCH] rtk_btusb: Add Bluetooth firmware

On Thu, 2012-12-20 at 20:37 -0600, Larry Finger wrote:
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> Signed-off-by: Champion Chen <champion_chen@...lsil.com.cn>
> ---
>  WHENCE              |    8 ++++++++
>  rtl_bt/rtl8723a.bin |  Bin 0 -> 23772 bytes
>  2 files changed, 8 insertions(+)
>  create mode 100644 rtl_bt/rtl8723a.bin
> 
> diff --git a/WHENCE b/WHENCE
> index 3b2f282..f485111 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -1811,6 +1811,14 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
>  
>  --------------------------------------------------------------------------
>  
> +Driver: rtk_btusb - Realtek Bluetooth driver
> +
> +Info: Supplied by champion_chen@...lsil.com.cn along with driver source code
> +File: rtl_bt/rtl8723a.bin
> +
> +Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
[...]

There seem to be some serious problems with the driver that uses this.
So, if this is not already in use with an external firmware blob, could
you perhaps add some sort of header to the blob and have the driver make
some sanity checks before uploading to the device?

Ben.

-- 
Ben Hutchings
Every program is either trivial or else contains at least one bug

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)