linux-kernel - Re: [PATCH] rtk_btusb: Add Bluetooth firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50DA5FF0.2010300@lwfinger.net>
Date:	Tue, 25 Dec 2012 20:24:48 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	dwmw2@...radead.org, Champion Chen <champion_chen@...lsil.com.cn>
Subject: Re: [PATCH] rtk_btusb: Add Bluetooth firmware

On 12/25/2012 05:26 PM, Ben Hutchings wrote:
> On Thu, 2012-12-20 at 20:37 -0600, Larry Finger wrote:
>> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
>> Signed-off-by: Champion Chen <champion_chen@...lsil.com.cn>
>> ---
>>   WHENCE              |    8 ++++++++
>>   rtl_bt/rtl8723a.bin |  Bin 0 -> 23772 bytes
>>   2 files changed, 8 insertions(+)
>>   create mode 100644 rtl_bt/rtl8723a.bin
>>
>> diff --git a/WHENCE b/WHENCE
>> index 3b2f282..f485111 100644
>> --- a/WHENCE
>> +++ b/WHENCE
>> @@ -1811,6 +1811,14 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
>>
>>   --------------------------------------------------------------------------
>>
>> +Driver: rtk_btusb - Realtek Bluetooth driver
>> +
>> +Info: Supplied by champion_chen@...lsil.com.cn along with driver source code
>> +File: rtl_bt/rtl8723a.bin
>> +
>> +Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
> [...]
>
> There seem to be some serious problems with the driver that uses this.
> So, if this is not already in use with an external firmware blob, could
> you perhaps add some sort of header to the blob and have the driver make
> some sanity checks before uploading to the device?

Yes, I will add a header and the necessary checking. At that point, I will then 
resubmit.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/