lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LNX.2.00.1212262246390.23814@swampdragon.chaosbits.net> Date: Wed, 26 Dec 2012 22:49:40 +0100 (CET) From: Jesper Juhl <jj@...osbits.net> To: netfilter@...r.kernel.org cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, coreteam@...filter.org, netfilter-devel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Patrick McHardy <kaber@...sh.net>, Pablo Neira Ayuso <pablo@...filter.org>, Jay Schulist <jschlst@...ba.org>, Harald Welte <laforge@...monks.org> Subject: [PATCH] netfilter: Don't leak 'exp' in ctnetlink_create_expect() 'if ((!help) && (!cda[CTA_EXPECT_TIMEOUT]))' then we should remember to free 'exp' that was allocated by 'nf_ct_expect_alloc()' by jumping to the 'err_out' label rather than the 'out' label in ctnetlink_create_expect(). This patch should get rid of the leak. Signed-off-by: Jesper Juhl <jj@...osbits.net> --- net/netfilter/nf_conntrack_netlink.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) note: compile tested only. diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index 4e078cd..627b0e5 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -2624,7 +2624,7 @@ ctnetlink_create_expect(struct net *net, u16 zone, if (!help) { if (!cda[CTA_EXPECT_TIMEOUT]) { err = -EINVAL; - goto out; + goto err_out; } exp->timeout.expires = jiffies + ntohl(nla_get_be32(cda[CTA_EXPECT_TIMEOUT])) * HZ; -- 1.7.1 -- Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists