linux-kernel - Re: [PATCH] netfilter: Don't leak 'exp' in ctnetlink_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121226220902.GA30981@1984>
Date:	Wed, 26 Dec 2012 23:09:02 +0100
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	netfilter@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, coreteam@...filter.org,
	netfilter-devel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Patrick McHardy <kaber@...sh.net>,
	Jay Schulist <jschlst@...ba.org>,
	Harald Welte <laforge@...monks.org>
Subject: Re: [PATCH] netfilter: Don't leak 'exp' in
 ctnetlink_create_expect()

On Wed, Dec 26, 2012 at 10:49:40PM +0100, Jesper Juhl wrote:
> 'if ((!help) && (!cda[CTA_EXPECT_TIMEOUT]))' then we should remember
> to free 'exp' that was allocated by 'nf_ct_expect_alloc()' by jumping
> to the 'err_out' label rather than the 'out' label in
> ctnetlink_create_expect().
> This patch should get rid of the leak.

Applied, thanks Jesper.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/