lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20121226.141350.999199516661256197.davem@davemloft.net> Date: Wed, 26 Dec 2012 14:13:50 -0800 (PST) From: David Miller <davem@...emloft.net> To: akinobu.mita@...il.com Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, lindner_marek@...oo.de, siwu@....tu-chemnitz.de, ordex@...istici.org, b.a.t.m.a.n@...ts.open-mesh.org Subject: Re: [PATCH] batman-adv: fix random jitter calculation From: Akinobu Mita <akinobu.mita@...il.com> Date: Wed, 26 Dec 2012 21:32:10 +0900 > batadv_iv_ogm_emit_send_time() attempts to calculates a random integer > in the range of 'orig_interval +- BATADV_JITTER' by the below lines. > > msecs = atomic_read(&bat_priv->orig_interval) - BATADV_JITTER; > msecs += (random32() % 2 * BATADV_JITTER); > > But it actually gets 'orig_interval' or 'orig_interval - BATADV_JITTER' > because '%' and '*' have same precedence and associativity is > left-to-right. > > This adds the parentheses at the appropriate position so that it matches > original intension. > > Signed-off-by: Akinobu Mita <akinobu.mita@...il.com> > Acked-by: Antonio Quartulli <ordex@...istici.org> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists