linux-kernel - Re: [PATCH review] f2fs: Don't assign e_id in f2fs_acl_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Dec 2012 11:48:26 +0900
From:	Jaegeuk Kim <jaegeuk.kim@...sung.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Linux Containers <containers@...ts.linux-foundation.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Amit Sahrawat <a.sahrawat@...sung.com>
Subject: Re: [PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk

2012-12-25 (화), 16:41 -0800, Eric W. Biederman:
> With user namespaces enabled building f2fs fails with:
> 
>  CC      fs/f2fs/acl.o
> fs/f2fs/acl.c: In function ‘f2fs_acl_from_disk’:
> fs/f2fs/acl.c:85:21: error: ‘struct posix_acl_entry’ has no member named ‘e_id’
> make[2]: *** [fs/f2fs/acl.o] Error 1
> make[2]: Target `__build' not remade because of errors.
> 
> e_id is a backwards compatibility field only used for file systems
> that haven't been converted to use kuids and kgids.  When the posix
> acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is
> unnecessary.  Remove the assignment so f2fs will build with user
> namespaces enabled.
> 
> Cc: Jaegeuk Kim <jaegeuk.kim@...sung.com>
> Cc: Namjae Jeon <namjae.jeon@...sung.com>
> Cc: Amit Sahrawat <a.sahrawat@...sung.com>
> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Acked-by: Jaegeuk Kim <jaegeuk.kim@...sung.com>

-- 
Jaegeuk Kim
Samsung

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)