lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87obhh63wz.fsf@xmission.com> Date: Tue, 25 Dec 2012 16:41:16 -0800 From: ebiederm@...ssion.com (Eric W. Biederman) To: Linux Containers <containers@...ts.linux-foundation.org> Cc: <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Jaegeuk Kim <jaegeuk.kim@...sung.com>, Namjae Jeon <namjae.jeon@...sung.com>, Amit Sahrawat <a.sahrawat@...sung.com> Subject: [PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk With user namespaces enabled building f2fs fails with: CC fs/f2fs/acl.o fs/f2fs/acl.c: In function ‘f2fs_acl_from_disk’: fs/f2fs/acl.c:85:21: error: ‘struct posix_acl_entry’ has no member named ‘e_id’ make[2]: *** [fs/f2fs/acl.o] Error 1 make[2]: Target `__build' not remade because of errors. e_id is a backwards compatibility field only used for file systems that haven't been converted to use kuids and kgids. When the posix acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is unnecessary. Remove the assignment so f2fs will build with user namespaces enabled. Cc: Jaegeuk Kim <jaegeuk.kim@...sung.com> Cc: Namjae Jeon <namjae.jeon@...sung.com> Cc: Amit Sahrawat <a.sahrawat@...sung.com> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com> --- Barring other feedback I will push this change to Linus with my other namespace bug fixes in the next day or two. fs/f2fs/acl.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c index fed74d1..e95b949 100644 --- a/fs/f2fs/acl.c +++ b/fs/f2fs/acl.c @@ -82,7 +82,6 @@ static struct posix_acl *f2fs_acl_from_disk(const char *value, size_t size) case ACL_GROUP_OBJ: case ACL_MASK: case ACL_OTHER: - acl->a_entries[i].e_id = ACL_UNDEFINED_ID; entry = (struct f2fs_acl_entry *)((char *)entry + sizeof(struct f2fs_acl_entry_short)); break; -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists