linux-kernel - Re: [PATCH] samsung-laptop: Set keyboard backlight initially

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHR064iThHwC17=fgkdC5Kth+Mn4uAQfNA1DDFnAbTJigYK2ww@mail.gmail.com>
Date:	Thu, 3 Jan 2013 20:46:12 +0000
From:	Corentin Chary <corentin.chary@...il.com>
To:	Roland Stigge <stigge@...com.de>
Cc:	gregkh@...uxfoundation.org, Matthew Garrett <mjg@...hat.com>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] samsung-laptop: Set keyboard backlight initially

Sorry for the lag...

On Mon, Dec 24, 2012 at 12:55 PM, Roland Stigge <stigge@...com.de> wrote:
> On 24/12/12 09:41, Corentin Chary wrote:
>> On Sun, Dec 23, 2012 at 6:21 PM, Roland Stigge <stigge@...com.de> wrote:
>>> After boot, /sys/devices/platform/samsung/leds/samsung::kbd_backlight/brightness
>>> shows the maximum value (8) by readout, but the led is off. I need to manually
>>> set it to the respective value to have keyboard backlight.
>>
>> If the led is set to 0, what's the value after reboot ? 0 or 8 ?
>
> Right - when writing 0 there before restart, the led value is actually 8
> after reboot, and the LED hardware is ON. This holds for both reboot and
> halt+poweron cycle.

Ok,

> Maybe this is related to the "#define MAX_BRIGHT 0x07" (which is unused
> in samsung-laptop.c)? A bit confusing in the code - but your question
> hints for some other bug (to be solved differently). Tell me if I can
> help somehow, here.

I don't think this is really used.

>> What's the behavior on windows ?
>
> There is no windows available on this machine.

Too bad, let's assume your patch is the best behavior :). Will merge it soon.



--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/