linux-kernel - Re: [PATCH v3 3/8] MFD:rtsx: Declare that the DMA address limitationis32bit explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130104055031.GQ7247@mwanda>
Date:	Fri, 4 Jan 2013 08:50:31 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	wwang <wei_wang@...lsil.com.cn>
Cc:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"oakad@...oo.com" <oakad@...oo.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arnd@...db.de" <arnd@...db.de>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"bp@...en8.de" <bp@...en8.de>, "cjb@...top.org" <cjb@...top.org>
Subject: Re: [PATCH v3 3/8] MFD:rtsx: Declare that the DMA address
 limitationis32bit explicitly

On Fri, Jan 04, 2013 at 10:46:22AM +0800, wwang wrote:
> 于 2013年01月03日 20:25, Dan Carpenter 写道:
> > On Fri, Dec 28, 2012 at 10:41:28AM +0800, wei_wang@...lsil.com.cn wrote:
> >> From: Wei WANG <wei_wang@...lsil.com.cn>
> >>
> >> Realtek PCIe card reader only supports 32bit DMA
> >>
> > Is this a bugfix?  If so what does the bug look like?
> >
> > regards,
> > dan carpenter
> >
> Hi Dan:
> 
> No, this is not a bugfix. In default, the kernel will allocate 32bit
> address for DMA. This declaration can improve the readability.
> 

Ah ok.  Really none of the things I mentioned were stuff that
prevented the patch from being merged or couldn't be fixed in follow
on patches.

The thing is that the commit message should always say why a patch
is needed.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/