linux-kernel - Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ6Av5MP8gjck=WqjLJMLEtHbbaMOT2aFxExP4YkGScE-O0L8A@mail.gmail.com>
Date:	Sat, 5 Jan 2013 05:17:10 -0600
From:	Omar Ramirez Luna <omar.ramirez@...itl.com>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src
 length checking issue.

Hi,

On Thu, Dec 13, 2012 at 9:50 PM, Chen Gang <gang.chen@...anux.com> wrote:
>   in drivers/staging/tidspbridge/rmgr/proc.c:
>
>     if strlen(drv_datap->base_img) == size, will pass checking (line 397)
>     the size is the full length of exec_file (line 382, line 468..469)
>     strcpy causes issue: src len is strlen(drv_datap->base_img) + '\0'. (line 400)

Good catch.

>     strncpy seems also has issue: need use size instead of strlen(iva_img) + 1. (line 402..403)

This code is not used, it is best to remove it.

Cheers,

Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/