[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <50E80D6A.2050702@asianux.com>
Date: Sat, 05 Jan 2013 19:24:26 +0800
From: Chen Gang <gang.chen@...anux.com>
To: Omar Ramirez Luna <omar.ramirez@...itl.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy,
src length checking issue.
于 2013年01月05日 19:17, Omar Ramirez Luna 写道:
> Hi,
>
> On Thu, Dec 13, 2012 at 9:50 PM, Chen Gang <gang.chen@...anux.com> wrote:
>> in drivers/staging/tidspbridge/rmgr/proc.c:
>>
>> if strlen(drv_datap->base_img) == size, will pass checking (line 397)
>> the size is the full length of exec_file (line 382, line 468..469)
>> strcpy causes issue: src len is strlen(drv_datap->base_img) + '\0'. (line 400)
>
> Good catch.
>
>> strncpy seems also has issue: need use size instead of strlen(iva_img) + 1. (line 402..403)
>
> This code is not used, it is best to remove it.
>
thank you.
:-)
gchen
> Cheers,
>
> Omar
>
>
--
Chen Gang
Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists