linux-kernel - Re: [PATCH] SPI: SSP SPI Controller driver v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaw7Yc0OetPWK7Cv=JsVPOs6b1Tr-=4jE5Vz4oTD6f07Q@mail.gmail.com>
Date:	Mon, 7 Jan 2013 00:36:07 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	chao bi <chao.bi@...el.com>, grant.likely@...retlab.ca,
	linux-kernel@...r.kernel.org, sylvain.centelles@...el.com,
	ken.k.mills@...el.com, jun.d.chen@...el.com, alan@...ux.intel.com
Subject: Re: [PATCH] SPI: SSP SPI Controller driver v3

On Wed, Dec 19, 2012 at 10:56 AM, Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
> On Tue, Dec 18, 2012 at 04:11:36PM +0800, chao bi wrote:
>>
>> This patch is to implement SSP SPI controller driver, which has been applied and
>> validated on intel Moorestown & Medfield platform. The patch are originated by
>> Ken Mills <ken.k.mills@...el.com> and Sylvain Centelles <sylvain.centelles@...el.com>,
>> migrating to lateset Linux mainline SPI framework by Channing <chao.bi@...el.com>
>> and Chen Jun <jun.d.chen@...el.com> according to their integration & validation
>> on Medfield platform.
>
> This is the same IP block as used in PXA, right? With few modifications
> here and there. Is there a reason not to use spi-pxa2xx.c?

This needs to be investigated. Two drivers for the same or closely related
hardware block is never a good sign...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/