linux-kernel - RE: [PATCH RFT] regulator: lp8788-ldo: Use ldo->en_pin to check if regulator is enabled by external pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A874F61F95741C4A9BA573A70FE3998F69E117BB@DQHE02.ent.ti.com>
Date:	Mon, 7 Jan 2013 01:17:08 +0000
From:	"Kim, Milo" <Milo.Kim@...com>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"Girdwood, Liam" <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH RFT] regulator: lp8788-ldo: Use ldo->en_pin to check if
 regulator is enabled by external pin

Hi Axel,

> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@...ics.com]
> Sent: Saturday, January 05, 2013 4:34 PM
> To: Mark Brown
> Cc: Kim, Milo; Girdwood, Liam; linux-kernel@...r.kernel.org
> Subject: [PATCH RFT] regulator: lp8788-ldo: Use ldo->en_pin to check if
> regulator is enabled by external pin
> 
> ldo->en_pin is set iff the regulator is enabled by external pin.
> 
> This patch sets ldo->en_pin to NULL if lp8788_gpio_request_ldo_en()
> fails, then
> we can use it to determinate if the regulator is controlled by external
> pin or
> register.
> 
> lp8788_get_ldo_enable_mode(), lp8788_ldo_ctrl_by_extern_pin() and
> lp8788_ldo_is_enabled_by_extern_pin() functions are not used now,
> remove them.

I love this patch and it works in a real board.

Initial driver code controls LDOs by reading the regulator control mode.
It guarantees working even if the control mode is changed by mistake.
But this case can be fixed using LP8788 platform data.
This patch makes the driver simpler, so I do ack your patch.
Thanks!

Acked-by: Milo Kim <milo.kim@...com>
Tested-by: Milo Kim <milo.kim@...com>