linux-kernel - Re: [PATCH RFT] regulator: lp8788-ldo: Use ldo->en_pin to check if regulator is enabled by external pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130107110818.GB4544@opensource.wolfsonmicro.com>
Date:	Mon, 7 Jan 2013 11:08:18 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	"Milo(Woogyom) Kim" <milo.kim@...com>, Liam Girdwood <lrg@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFT] regulator: lp8788-ldo: Use ldo->en_pin to check if
 regulator is enabled by external pin

On Sat, Jan 05, 2013 at 03:33:43PM +0800, Axel Lin wrote:
> ldo->en_pin is set iff the regulator is enabled by external pin.
> 
> This patch sets ldo->en_pin to NULL if lp8788_gpio_request_ldo_en() fails, then
> we can use it to determinate if the regulator is controlled by external pin or
> register.

Applied, thanks.  However we should be converting the driver to use the
core support for this - the GPIO can just be given to the core in the
regulator config which should handle everything transparently.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)