linux-kernel - Re: [PATCH] drivers/staging/speakup: avoid out-of-range access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130107174453.GA15120@kroah.com>
Date:	Mon, 7 Jan 2013 09:44:53 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Samuel Thibault <samuel.thibault@...-lyon.org>,
	Nickolai Zeldovich <nickolai@...il.mit.edu>,
	William Hubbs <w.d.hubbs@...il.com>,
	Chris Brannon <chris@...-brannons.com>,
	Kirk Reiser <kirk@...ille.uwo.ca>,
	linux-kernel@...r.kernel.org, speakup@...ille.uwo.ca
Subject: Re: [PATCH] drivers/staging/speakup: avoid out-of-range access

On Sat, Jan 05, 2013 at 08:29:44PM +0100, Samuel Thibault wrote:
> Indeed. The same happens in synth_add, so Greg please use this instead:
> 
> 
> Check that array index is in-bounds before accessing the synths[] array.
> 
> Signed-off-by: Nickolai Zeldovich <nickolai@...il.mit.edu>
> Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>

Wait, Nickolai wrote the first patch, so how could he sign off on your
patch?  How about sending me an add-on patch on top of the first one
which adds the additional check?  That way I'll apply both of them and
everyone will get the proper credit?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/