linux-kernel - Re: [PATCH] drivers/staging/speakup: avoid out-of-range access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130107210351.GJ5998@type.youpi.perso.aquilenet.fr>
Date:	Mon, 7 Jan 2013 22:03:51 +0100
From:	Samuel Thibault <samuel.thibault@...-lyon.org>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Nickolai Zeldovich <nickolai@...il.mit.edu>,
	William Hubbs <w.d.hubbs@...il.com>,
	Chris Brannon <chris@...-brannons.com>,
	Kirk Reiser <kirk@...ille.uwo.ca>,
	linux-kernel@...r.kernel.org, speakup@...ille.uwo.ca
Subject: Re: [PATCH] drivers/staging/speakup: avoid out-of-range access

Greg KH, le Mon 07 Jan 2013 09:44:53 -0800, a écrit :
> Wait, Nickolai wrote the first patch, so how could he sign off on your
> patch?  How about sending me an add-on patch on top of the first one
> which adds the additional check?

Right, here it is:


Check that array index is in-bounds before accessing the synths[] array.

Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>

---
 drivers/staging/speakup/synth.c |    2 +-
 1 file changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index df95337..b91d22b 100644
--- a/drivers/staging/speakup/synth.c
+++ b/drivers/staging/speakup/synth.c
@@ -423,7 +423,7 @@ int synth_add(struct spk_synth *in_synth
 	int i;
 	int status = 0;
 	mutex_lock(&spk_mutex);
-	for (i = 0; synths[i] != NULL && i < MAXSYNTHS; i++)
+	for (i = 0; i < MAXSYNTHS && synths[i] != NULL; i++)
 		/* synth_remove() is responsible for rotating the array down */
 		if (in_synth == synths[i]) {
 			mutex_unlock(&spk_mutex);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/