linux-kernel - RE: [PATCH 2/2] Staging: comedi: addi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ADE657CA350FB648AAC2C43247A983F00206D6C98F77@AUSP01VMBX24.collaborationhost.net>
Date:	Mon, 7 Jan 2013 16:50:55 -0600
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Greg KH <gregkh@...uxfoundation.org>,
	Lijo Antony <lijo.kernel@...il.com>
CC:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"fmhess@...rs.sourceforge.net" <fmhess@...rs.sourceforge.net>,
	"abbotti@....co.uk" <abbotti@....co.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] Staging: comedi: addi_common.h: checkpatch.pl fixes

On Monday, January 07, 2013 3:40 PM, Greg KH wrote:
> On Sat, Jan 05, 2013 at 06:12:55PM +0400, Lijo Antony wrote:
>> Reduced line lengths to 80 chars by removing extra spaces.
>> 
>> Signed-off-by: Lijo Antony <lijo.kernel@...il.com>
>> ---
>>  .../staging/comedi/drivers/addi-data/addi_common.h |   20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)

<snip>

> As you didn't do this for all fields in the structure, it's not really
> worth doing it for just these, right?
>
> The proper thing to do is use kerneldoc format and document it all at
> the top of the structure, care to do that instead?

Hopefully I will soon get the rest of the addi-data drivers split off of the
addi_common stuff. This will effectively remove this header file so I'm
not sure it's worth making patches against it.

Regards,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/