linux-kernel - RE: [v3 PATCH 05/12] spi/atmel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B256D81BAE5131468A838E5D7A2436413A05704A@penmbx02>
Date:	Tue, 8 Jan 2013 01:02:01 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	Joe Perches <joe@...ches.com>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"plagnioj@...osoft.com" <plagnioj@...osoft.com>,
	"richard.genoud@...il.com" <richard.genoud@...il.com>,
	"Lin, JM" <JM.Lin@...el.com>
Subject: RE: [v3 PATCH 05/12] spi/atmel_spi: update the dt support



> -----Original Message-----
> From: Joe Perches [mailto:joe@...ches.com]
> Sent: 2013年1月7日 10:06
> To: Yang, Wenyou
> Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Ferre,
> Nicolas; plagnioj@...osoft.com; richard.genoud@...il.com; Lin, JM
> Subject: Re: [v3 PATCH 05/12] spi/atmel_spi: update the dt support
> 
> On Mon, 2013-01-07 at 09:50 +0800, Wenyou Yang wrote:
> > To meet the different spi IP version of atmel SoC,
> > add more compatible "atmel,at91rm9200-spi", "atmel,at91sam9260-spi"
> > "atmel,at91sam9g45-spi", "atmel,at91sam9x5-spi" with different
> > config and devtype.
> 
> trivial comment:
> 
> > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> []
> > @@ -230,11 +302,15 @@ struct atmel_spi_device {
> >   * register, but I haven't checked that it exists on all chips, and
> >   * this is cheaper anyway.
> >   */
> > -static bool atmel_spi_is_v2(void)
> > +static bool atmel_spi_is_v2(struct atmel_spi *as)
> 
> There's a comment that needs updating above this now
> 
> >  {
> > -	return !cpu_is_at91rm9200();
> > +	if (as->pdata->version == 2)
> > +		return true;
> > +	else
> > +		return false;
> 
> 	return as->pdata->version == 2;
> 
> is rather more readable to me

Thanks a lot for quick feedback.
I will change it next version.
>