linux-kernel - RE: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Jan 2013 01:29:44 +0000
From:	"Kim, Milo" <Milo.Kim@...com>
To:	Jason Cooper <jason@...edaemon.net>,
	Josh Coombs <josh.coombs@...il.com>
CC:	"cooloney@...il.com" <cooloney@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
	"rpurdie@...ys.net" <rpurdie@...ys.net>,
	linux ARM <linux-arm-kernel@...ts.infradead.org>,
	"jgarzik@...ox.com" <jgarzik@...ox.com>,
	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>
Subject: RE: [PATCH] Allow Marvell SATA driver to work with
 LEDS_TRIGGER_IDE_DISK

> -----Original Message-----
> From: linux-leds-owner@...r.kernel.org [mailto:linux-leds-
> owner@...r.kernel.org] On Behalf Of Jason Cooper
> Sent: Wednesday, January 09, 2013 5:04 AM
> To: Josh Coombs
> Cc: cooloney@...il.com; linux-kernel@...r.kernel.org; linux-
> ide@...r.kernel.org; rpurdie@...ys.net; linux ARM; jgarzik@...ox.com;
> linux-leds@...r.kernel.org
> Subject: Re: [PATCH] Allow Marvell SATA driver to work with
> LEDS_TRIGGER_IDE_DISK
> 
> On Tue, Jan 08, 2013 at 02:18:04PM -0500, Josh Coombs wrote:
> > Would it make more sense to add a second trigger
> > for SATA instead?
> 
> I'll leave that up to the led guys, I just wanted to raise the point
> that the driver could logically support other types of disks, and we
> should come up with a migration path instead of adding capabilities
> ad-hoc.

I agree with Jason's suggestion. One more thing to consider.

If we replace the name, 'ide-disk' or 'ide_disk' with general one,
then we should change the value of 'default_trigger' under arch directory also.
LED trigger works if the name is matched with trigger name of LED device.

Thanks,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/