linux-kernel - Re: USB autosuspend vs. URB submission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1643419.R9VmOAX4j3@linux-5eaq.site>
Date:	Thu, 10 Jan 2013 10:42:37 +0100
From:	Oliver Neukum <oneukum@...e.de>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	Josh Boyer <jwboyer@...hat.com>,
	Alan Stern <stern@...land.harvard.edu>,
	gregkh@...uxfoundation.org, mdharm-usb@...-eyed-alien.net,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: USB autosuspend vs. URB submission

On Thursday 10 January 2013 00:05:55 Laurent Pinchart wrote:

> I've had a quick look at the trace posted at 
> https://bugzilla.redhat.com/show_bug.cgi?id=879462 but usbmon only shows URBs 
> that are successfully submitted. I'm not sure what useful information I could 
> get from the trace.

The test is at the very start of usb_submit_urb()

        if (!urb || !urb->complete)
                return -EINVAL;
        if (urb->hcpriv) { 
                WARN_ONCE(1, "URB %p submitted while active\n", urb);
                return -EBUSY;
        }

usbmon will never see such URBs

I suggest that for debugging you change the WARN_ONCE into a WARN and compare
the URB pointers of usbmon and dmesg.

In the long run it is probably a good idea to pass duplicated URBs to usbmon by
a special code path.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/