linux-kernel - Re: USB autosuspend vs. URB submission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5203913.6Ij3EG26lC@linux-5eaq.site>
Date:	Thu, 10 Jan 2013 11:02:11 +0100
From:	Oliver Neukum <oneukum@...e.de>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Josh Boyer <jwboyer@...hat.com>,
	Alan Stern <stern@...land.harvard.edu>,
	gregkh@...uxfoundation.org, mdharm-usb@...-eyed-alien.net,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: USB autosuspend vs. URB submission

On Thursday 10 January 2013 13:13:58 Ming Lei wrote:
> IMO, there is a minor fault in the error handling path of
> uvc_status_start() inside uvc_v4l2_open(), and the 'users' count
> should have been decreased before usb_autopm_put_interface().
> In theory, the warning can be triggered when the device is
> opened just between usb_autopm_put_interface() and
> atomic_dec(&stream->dev->users), but I don't think it is
> the cause of the report.

Hi,

the analysis is sound. Good catch. As the fix is trivial, I am making
a quick patch.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/