linux-kernel - Re: [PATCH 1/3] driver core: add helper macro for platform_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHkwnC8bmDxZdy=xos6AnG1vPDtGhGF6S8FYFfbdKG9vrHCnYw@mail.gmail.com>
Date:	Thu, 10 Jan 2013 13:50:48 +0100
From:	Fabio Porcedda <fabio.porcedda@...il.com>
To:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-watchdog@...r.kernel.org, linux-usb@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/3] driver core: add helper macro for platform_driver_probe()
 boilerplate

Hi Greg,
I'm sorry, In the previous email I used your wrong email address,
in this email I've used your correct email address.

Best regards
Fabio Porcedda

On Wed, Jan 9, 2013 at 12:15 PM, Fabio Porcedda
<fabio.porcedda@...il.com> wrote:
> For simple modules that contain a single platform_driver without any
> additional setup code then ends up being a block of duplicated
> boilerplate.  This patch adds a new macro,
> module_platform_driver_probe(), which replaces the
> module_init()/module_exit() registrations with template functions.
>
> This macro use the same idea of module_platform_driver().
>
> This macro is useful to stop the misuse of module_platform_driver() for
> removing the platform_driver_probe() boilerplate.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@...il.com>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>

Cc: Greg Kroah-Hartman (linuxfoundation.org)

> ---
>  include/linux/platform_device.h | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h
> index a9ded9a..c082c71 100644
> --- a/include/linux/platform_device.h
> +++ b/include/linux/platform_device.h
> @@ -204,6 +204,24 @@ static inline void platform_set_drvdata(struct platform_device *pdev, void *data
>         module_driver(__platform_driver, platform_driver_register, \
>                         platform_driver_unregister)
>
> +/* module_platform_driver_probe() - Helper macro for drivers that don't do
> + * anything special in module init/exit.  This eliminates a lot of
> + * boilerplate.  Each module may only use this macro once, and
> + * calling it replaces module_init() and module_exit()
> + */
> +#define module_platform_driver_probe(__platform_driver, __platform_probe) \
> +static int __init __platform_driver##_init(void) \
> +{ \
> +       return platform_driver_probe(&(__platform_driver), \
> +                                    __platform_probe);    \
> +} \
> +module_init(__platform_driver##_init); \
> +static void __exit __platform_driver##_exit(void) \
> +{ \
> +       platform_driver_unregister(&(__platform_driver)); \
> +} \
> +module_exit(__platform_driver##_exit);
> +
>  extern struct platform_device *platform_create_bundle(struct platform_driver *driver,
>                                         int (*probe)(struct platform_device *),
>                                         struct resource *res, unsigned int n_res,
> --
> 1.8.0.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/