linux-kernel - Re: [PATCH 1/2] tuntap: forbid calling TUNSETIFF when detached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1357916147.27446.3653.camel@edumazet-glaptop>
Date:	Fri, 11 Jan 2013 06:55:47 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jason Wang <jasowang@...hat.com>
Cc:	davem@...emloft.net, mst@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Stefan Hajnoczi <stefanha@...hat.com>
Subject: Re: [PATCH 1/2] tuntap: forbid calling TUNSETIFF when detached

On Fri, 2013-01-11 at 16:50 +0800, Jason Wang wrote:

>  
> +	if (rcu_dereference_protected(tfile->detached, lockdep_rtnl_is_held()))
> +		return -EINVAL;
> +

Thats an open coded rtnl_dereference()

(please cleanup the whole tun.c file)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/