lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1357996822-13072-1-git-send-email-holler@ahsoftware.de> Date: Sat, 12 Jan 2013 14:20:22 +0100 From: Alexander Holler <holler@...oftware.de> To: linux-kernel@...r.kernel.org Cc: linux-fbdev@...r.kernel.org, Bernie Thompson <bernie@...gable.com>, Florian Tobias Schandinat <FlorianSchandinat@....de>, Alan Cox <alan@...rguk.ukuu.org.uk>, Steve Glendinning <steve.glendinning@...well.net>, Dave Airlie <airlied@...hat.com>, Alexander Holler <holler@...oftware.de>, <stable@...r.kernel.org> Subject: [PATCH] fb: udlfb: fix hang at disconnect When a device was disconnected the driver may hang at waiting for urbs it never will get. Fix this by using a timeout while waiting for the used semaphore. There is still a memory leak if a timeout happens, but at least the driver now continues his disconnect routine. Cc: <stable@...r.kernel.org> Signed-off-by: Alexander Holler <holler@...oftware.de> --- drivers/video/udlfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c index 86d449e..cc4a8d1 100644 --- a/drivers/video/udlfb.c +++ b/drivers/video/udlfb.c @@ -1832,8 +1832,8 @@ static void dlfb_free_urb_list(struct dlfb_data *dev) /* keep waiting and freeing, until we've got 'em all */ while (count--) { - /* Getting interrupted means a leak, but ok at disconnect */ - ret = down_interruptible(&dev->urbs.limit_sem); + /* Timeout likely occurs at disconnect (resulting in a leak) */ + ret = down_timeout(&dev->urbs.limit_sem, GET_URB_TIMEOUT); if (ret) break; -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists