linux-kernel - Re: [ 19/49] NFSv4: Add ACCESS operation to OPEN compound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130115184244.GB3408@herton-Z68MA-D2H-B3>
Date:	Tue, 15 Jan 2013 16:42:45 -0200
From:	Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Weston Andros Adamson <dros@...app.com>,
	Trond Myklebust <Trond.Myklebust@...app.com>
Subject: Re: [ 19/49] NFSv4: Add ACCESS operation to OPEN compound

On Sun, Jan 13, 2013 at 05:43:14PM +0000, Ben Hutchings wrote:
> 3.2-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Weston Andros Adamson <dros@...app.com>
> 
> commit 6168f62cbde8dcf4f58255794efbcdb8df603959 upstream.
> 
> The OPEN operation has no way to differentiate an open for read and an
> open for execution - both look like read to the server. This allowed
> users to read files that didn't have READ access but did have EXEC access,
> which is obviously wrong.
> 
> This patch adds an ACCESS call to the OPEN compound to handle the
> difference between OPENs for reading and execution.  Since we're going
> through the trouble of calling ACCESS, we check all possible access bits
> and cache the results hopefully avoiding an ACCESS call in the future.
> 
> Signed-off-by: Weston Andros Adamson <dros@...app.com>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@...app.com>
> [bwh: Backported to 3.2:
>  - Adjust context
>  - #include <linux/export.h> in fs/nfs/dir.c]
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>

This 3.2 series lacks commit ae2bb03236fc978bdf673c19d39832500793b83c
pointed in its changelog as fixing a regression from this one.

-- 
[]'s
Herton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/